Modify

Ticket #11652 (closed Bugs: fixed)

Opened 20 months ago

Last modified 15 months ago

Checking __cpp_lib_integer_sequence

Reported by: Mikhail Strelnikov <mikhail.strelnikov@…> Owned by: olli
Milestone: To Be Determined Component: context
Version: Boost 1.59.0 Severity: Cosmetic
Keywords: Cc:

Description

In this line (boost/context/detail/config.hpp):

! defined(cpp_lib_integer_sequence) && cpp_lib_integer_sequence < 201304

If cpp_lib_integer_sequence is not defined, then it is zero and checking against 201304 is redundant - 0 is less than 201304.

If cpp_lib_integer_sequence is defined, then comparinson with 201304 is not evaluated because of short-circuiting.

I think "! defined(cpp_lib_integer_sequence)" should be removed.

Attachments

Change History

comment:1 Changed 20 months ago by Mikhail Strelnikov <mikhail.strelnikov@…>

  • Version changed from Boost 1.57.0 to Boost 1.59.0
  • Severity changed from Problem to Cosmetic

comment:2 Changed 20 months ago by Mikhail Strelnikov <mikhail.strelnikov@…>

  • Owner set to olli
  • Component changed from None to coroutine

comment:3 Changed 20 months ago by Mikhail Strelnikov <mikhail.strelnikov@…>

And, btw, this check won't work for clang+libc++ because of this bug https://llvm.org/bugs/show_bug.cgi?id=18584

comment:4 Changed 15 months ago by olli

  • Status changed from new to closed
  • Resolution set to fixed
  • Component changed from coroutine to context

fixed - in a little bit other way

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.