Modify

Ticket #1988 (closed Bugs: fixed)

Opened 6 years ago

Last modified 3 years ago

Boost.Config macros badly added.

Reported by: johnmaddock Owned by: johnmaddock
Milestone: Boost 1.36.0 Component: config
Version: Boost 1.35.0 Severity: Problem
Keywords: Cc: anthony.ajw@…;jeff@…

Description

The two macros:

BOOST_NO_THREADEX and BOOST_NO_GETSYSTEMTIMEASFILETIME, should be named BOOST_HAS_* since they describe non-standard features, and should probably be set in win32.hpp given that these are platform rather than compiler specific?

Changes would effect DateTime? and Thread libraries as well as Boost.Config.

There are also no docs or test cases for these.

Attachments

Change History

comment:1 Changed 3 years ago by mikhailberis

John/Anthony?,

Is this still an issue? Has this already been adressed and if not should this be broken up into smaller issues that can independently be addressed?

comment:2 Changed 3 years ago by anonymous

Yes it still appears to be an issue, these macros weren't added correctly to Boost.Config.

I don't see how this can be broken up into smaller issues though sorry...

John.

PS if someone takes this on, they will need to take the changes through into the release branch as well.

comment:3 Changed 3 years ago by mikhailberis

I'll see if I can get patches out and tests run to see whether I can take this on. I'll give it some time tomorrow morning (PHT), I'll update as I run into issues or whether I have progress appropriately.

comment:4 Changed 3 years ago by marshall

Dean - are you still going to do this?

Here's what a quick search turns up:

trunk marshall$ grep -r BOOST_NO_THREADEX *
boost/config/compiler/visualc.hpp:#  define BOOST_NO_THREADEX
libs/thread/src/win32/thread.cpp:#ifdef BOOST_NO_THREADEX

trunk marshall$ grep -r BOOST_NO_GETSYSTEMTIMEASFILETIME *
boost/config/compiler/visualc.hpp:#  define BOOST_NO_GETSYSTEMTIMEASFILETIME
boost/date_time/filetime_functions.hpp:#elif defined(BOOST_NO_GETSYSTEMTIMEASFILETIME)

If you don't have time, I can probably take care of this.

comment:5 Changed 3 years ago by mikhailberis

Nope, sorry about that -- please go ahead and take this one on. I shall punt this to you. :)

comment:6 Changed 3 years ago by marshall

(In [71533]) Renamed BOOST_NO_THREADEX -> BOOST_HAS_THREADEX and BOOST_NO_GETSYSTEMTIMEASFILETIME --> BOOST_HAS_GETSYSTEMTIMEASFILETIME - Refs #1988

comment:7 Changed 3 years ago by marshall

  • Status changed from new to closed
  • Resolution set to fixed

(In [71676]) Merge fixes to release; Fixes #1988

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.