Modify

Ticket #2785 (closed Patches: fixed)

Opened 5 years ago

Last modified 5 years ago

[patch] GCC Shadow errors in circular buffer

Reported by: dustin@… Owned by: jano_gaspar
Milestone: Boost 1.40.0 Component: circular_buffer
Version: Boost 1.38.0 Severity: Cosmetic
Keywords: Cc:

Description

Patch for shadow errors in circular buffer library

Attachments

circular_buffer.tar.gz Download (2.8 KB) - added by dustin@… 5 years ago.
trivial patch for shadow errors
circular_buffer.zip Download (3.5 KB) - added by dustin@… 5 years ago.
Updated version of trivial patch

Change History

Changed 5 years ago by dustin@…

trivial patch for shadow errors

comment:1 Changed 5 years ago by jano_gaspar

I don't like the the parameter name 'capacity_sz'. It reminds me the hungarian notation. Can be this changed to 'buffer_capacity'?

Changed 5 years ago by dustin@…

Updated version of trivial patch

comment:2 Changed 5 years ago by dustin@…

That sounds good to me.

comment:4 Changed 5 years ago by Dustin Spicuzza <dustin@…>

Jano,

I see this didn't get included in 1.39. Any chance it will make it in 1.40? I changed the variables as you asked. :)

comment:5 Changed 5 years ago by jano_gaspar

  • Status changed from new to closed
  • Resolution set to fixed
  • Milestone changed from Boost 1.39.0 to Boost 1.40.0

applied to trunk ... will be applied to release branch as soon as trunk passes unit tests

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.