Modify

Ticket #2827 (closed Bugs: fixed)

Opened 5 years ago

Last modified 5 years ago

boost::detail::is_abstract_imp2::s1: 64 bit truncation warning

Reported by: pelee@… Owned by: johnmaddock
Milestone: Boost 1.39.0 Component: type_traits
Version: Boost Release Branch Severity: Problem
Keywords: Cc:

Description

The constant detail::is_abstract_imp2::s1 is declared as unsigned, but initialized to the result of sizeof(). sizeof() returns a 64 bit value when compiled on a 64 bit target. This causes a 64-to-32 bit truncation warning on 64 bit targets.

One option would be to declare the constant to be of type size_t. I opted instead for a static_cast on the assumption that it would cause less disruption and that the sizeof() call in question would probably never return a value that required more than 32 bits.

template<class T>
struct is_abstract_imp2
{
   // Deduction fails if T is void, function type, 
   // reference type (14.8.2/2)or an abstract class type 
   // according to review status issue #337
   //
   template<class U>
   static type_traits::no_type check_sig(U (*)[1]);
   template<class U>
   static type_traits::yes_type check_sig(...);
   //
   // T must be a complete type, further if T is a template then
   // it must be instantiated in order for us to get the right answer:
   //
   BOOST_STATIC_ASSERT(sizeof(T) != 0);

   // GCC2 won't even parse this template if we embed the computation
   // of s1 in the computation of value.
#ifdef __GNUC__
   BOOST_STATIC_CONSTANT(unsigned, s1 = static_cast<unsigned>(sizeof(is_abstract_imp2<T>::template check_sig<T>(0))));
#else
#if BOOST_WORKAROUND(_MSC_FULL_VER, >= 140050000)
#pragma warning(push)
#pragma warning(disable:6334)
#endif
   BOOST_STATIC_CONSTANT(unsigned, s1 = static_cast<unsigned>(sizeof(check_sig<T>(0))));
#if BOOST_WORKAROUND(_MSC_FULL_VER, >= 140050000)
#pragma warning(pop)
#endif
#endif
    
   BOOST_STATIC_CONSTANT(bool, value = 
      (s1 == sizeof(type_traits::yes_type)));
};

Attachments

Change History

comment:1 Changed 5 years ago by johnmaddock

  • Status changed from new to closed
  • Resolution set to fixed

(In [51754]) Add is_virtual_base_of. Add extra tests for is_base_of to test virtual inheritance. Trivial warning fix for is_abstract: fixes #2827.

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.