Modify

Ticket #2902 (closed Bugs: fixed)

Opened 5 years ago

Last modified 5 years ago

Assignment within condition expression warning

Reported by: pete@… Owned by: djowel
Milestone: To Be Determined Component: spirit
Version: Boost 1.38.0 Severity: Cosmetic
Keywords: Cc:

Description

In many places in my own code I get the following warning from Microsoft compilers:

<boost\spirit\home\qi\detail\string_parse.hpp> line 22 : warning C4706: assignment within conditional expression

Of course on this occasion the assignment is safe and intended. However it is not a warning that we feel comfortable disabling globally. Hence it would be nice if the warning could be push'n'pop-ed inside Boost code to save client workarounds.

An alernative - moving the assignment inside the loop - has the potential for a slight performance loss - an extra iterator deference.

Attachments

Change History

comment:1 Changed 5 years ago by hkaiser

  • Status changed from new to closed
  • Resolution set to fixed

(In [53540]) Spirit: refactored loop to avoid warning about assignment in conditional expression (fix #2902)

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.