Modify

Ticket #3276 (closed Bugs: fixed)

Opened 5 years ago

Last modified 5 years ago

Boost::Accumulators::Statistics: Unused Variables and Globals Cause Warnings/Errors When Headers Are Not in System Path

Reported by: gerickson@… Owned by: eric_niebler
Milestone: To Be Determined Component: accumulator
Version: Boost 1.39.0 Severity: Problem
Keywords: Cc:

Description

I've recently added Boost 1.39.0 to an Xcode 3.1.3 project with the following warnings enabled in GCC/G++ 4.0.1:

-Werror -Wreturn-type -Wunused-function -Wunused-label -Wunused-variable -Wshadow

Unfortunately, when boost is not installed in a "system" path--as is the case here--unused and shadow variable warnings cause the build to fail when warnings are treated as errors. This issue last came up for me about a year ago in 1_35_0 with filesystem.hpp:

 http://article.gmane.org/gmane.comp.lib.boost.user/38297/match=shadow+variables+cause

The included headers this time are:

boost/accumulators/statistics/rolling_sum.hpp

To test and fix, I isolated with:

printf "#include <${BoostHeader?}>\nint main(void) { return 0; }" | /Developer/usr/bin/gcc-4.0 -x c++ -Wall -Wshadow -Werror -Wreturn-type -Wunused-function -Wunused-label -Wunused-parameter -Wunused-variable -Wunused-value -o test -I${BoostRoot?}/boost/include -

The patches to address this are attached and impact the headers below:

boost/accumulators/statistics/rolling_sum.hpp

Attachments

boost-04.patch Download (561 bytes) - added by gerickson@… 5 years ago.

Change History

Changed 5 years ago by gerickson@…

comment:1 Changed 5 years ago by eric_niebler

  • Status changed from new to assigned

comment:2 Changed 5 years ago by eric_niebler

  • Status changed from assigned to closed
  • Resolution set to fixed

(In [55050]) eliminate shadow warnings and unused variable warnings, fixes #3262, fixed #3276, fixes #3031

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.