Modify

Ticket #4385 (closed Patches: fixed)

Opened 4 years ago

Last modified 4 years ago

Avoid redefining BOOST_NO_TYPEID and BOOST_NO_RTTI for gcc 4.3+

Reported by: nigels.com@… Owned by: johnmaddock
Milestone: Boost 1.44.0 Component: config
Version: Boost 1.43.0 Severity: Cosmetic
Keywords: gcc BOOST_NO_TYPEID BOOST_NO_RTTI NaCl Cc:

Description

Our codebase is configured to use BOOST_NO_TYPEID and BOOST_NO_RTTI for various compiler toolchains. When we use gcc 4.4 as bundled in the Google Native Client (NaCl?) SDK for OSX and Linux, we see compilation warnings due to the autodetection as follows:

//
// RTTI and typeinfo detection is possible post gcc-4.3:
//
#if __GNUC__ * 100 + __GNUC_MINOR__ >= 403
#  ifndef __GXX_RTTI
#     define BOOST_NO_TYPEID
#     define BOOST_NO_RTTI
#  endif
#endif

Our proposed patch is to avoid redefining either of these:

//
// RTTI and typeinfo detection is possible post gcc-4.3:
//
#if __GNUC__ * 100 + __GNUC_MINOR__ >= 403
#  ifndef __GXX_RTTI
#    ifndef BOOST_NO_TYPEID
#      define BOOST_NO_TYPEID
#    endif
#    ifndef BOOST_NO_RTTI
#      define BOOST_NO_RTTI
#    endif
#  endif
#endif

Attachments

boost_gcc_redefines.diff Download (496 bytes) - added by nigels.com@… 4 years ago.
Patch for boost w.r.t revision 63409

Change History

Changed 4 years ago by nigels.com@…

Patch for boost w.r.t revision 63409

comment:1 Changed 4 years ago by steven_watanabe

  • Owner changed from vladimir_prus to johnmaddock
  • Component changed from build to config

comment:2 Changed 4 years ago by johnmaddock

  • Status changed from new to closed
  • Resolution set to fixed

(In [63439]) Patch for macro redefinitions. Fixes #4385.

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.