Modify

Ticket #4918 (closed Patches: fixed)

Opened 3 years ago

Last modified 3 years ago

concept_check.hpp triggers self-assignment warnings

Reported by: gromer@… Owned by: marshall
Milestone: To Be Determined Component: concept_check
Version: Boost 1.45.0 Severity: Problem
Keywords: Cc:

Description

boost/concept_check.hpp contains two instances of assigning a variable to itself. In context, this is perfectly safe (since the code should never actually be executed), but it nonetheless triggers gcc's -Wself-assign, cluttering the build output for those who have that flag set, and breaking the build for those who also set -Werror. So far as I can tell, this code can be trivially rewritten to avoid the warning without any correctness or performance impact (see the attached patch).

Attachments

selfassign.patch Download (1.8 KB) - added by gromer@… 3 years ago.
Patch to fix bug

Change History

Changed 3 years ago by gromer@…

Patch to fix bug

comment:1 Changed 3 years ago by Vicente Botet <vicente.botet@…>

  • Type changed from Bugs to Patches

comment:2 Changed 3 years ago by marshall

(In [67742]) Applied patch - refs #4918; will merge to release after tests cycle

comment:3 Changed 3 years ago by marshall

  • Owner changed from jsiek to marshall

comment:4 Changed 3 years ago by marshall

  • Status changed from new to closed
  • Resolution set to fixed

(In [67792]) Merging fixes to release; fixes #2294 fixes #4918 fixes #3645 refs #2823 refs #1427 refs #2893

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.