Modify

Ticket #5145 (closed Patches: fixed)

Opened 3 years ago

Last modified 3 years ago

Fixed warning: use of logical && with constant operand; switch to bitwise & or remove constant [-Wconstant-logical-operand]

Reported by: vvavrychuk@… Owned by: atompkins
Milestone: To Be Determined Component: uuid
Version: Boost 1.47.0 Severity: Problem
Keywords: Cc:

Description

Fixed warning: use of logical && with constant operand; switch to bitwise & or remove constant [-Wconstant-logical-operand]

Attachments

0002-Fixed-warning-use-of-logical-with-constant-operand-s.patch Download (1.1 KB) - added by anonymous 3 years ago.

Change History

comment:1 Changed 3 years ago by steven_watanabe

  • Owner changed from dave to atompkins

comment:2 Changed 3 years ago by marshall

Applying this patch causes two of the tests to fail (not surprisingly, since it changes the string representation when outputting as wide chars):

testing.capture-output ../../../bin.v2/libs/uuid/test/test_name_generator.test/clang-darwin-4.2.1/debug/test_name_generator.run
====== BEGIN OUTPUT ======
test_name_generator.cpp(32): test 'u == wcorrect' failed in function 'int main(int, char **)': 'c315270b-a466-5872-aca4-9626cec0f4be' != 'b9506613-2c04-512d-b8fe-bf8d0ba1b271'
test_name_generator.cpp(40): test 'u == wcorrect' failed in function 'int main(int, char **)': 'c315270b-a466-5872-aca4-9626cec0f4be' != 'b9506613-2c04-512d-b8fe-bf8d0ba1b271'
2 errors detected.

EXIT STATUS: 1
====== END OUTPUT ======

The test needs to be adjusted, too. ;-)

comment:3 Changed 3 years ago by marshall

(In [68866]) Fix bug in wide output; Refs #5145

comment:4 Changed 3 years ago by atompkins

  • Status changed from new to closed
  • Version changed from Boost Development Trunk to Boost 1.47.0
  • Resolution set to fixed
View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.