Modify

Ticket #5185 (closed Bugs: fixed)

Opened 3 years ago

Last modified 3 years ago

Shared library libboost_graph_parallel calls exit() or _exit()

Reported by: robert@… Owned by: asutton
Milestone: To Be Determined Component: graph
Version: Boost 1.46.0 Severity: Problem
Keywords: Cc: mcepl@…

Description

During a package review at Fedora ( https://bugzilla.redhat.com/show_bug.cgi?id=673839) our rpmlint warned, that the shared library libboost_graph_parallel calls exit() or _exit():

boost-graph-mpich2.i686: W: shared-lib-calls-exit /usr/lib/mpich2/lib/libboost_graph_parallel.so.1.46.0 exit@GLIBC_2.0
This library package calls exit() or _exit(), probably in a non-fork()
context. Doing so from a library is strongly discouraged - when a library
function calls exit(), it prevents the calling program from handling the
error, reporting it to the user, closing files properly, and cleaning up any
state that the program has. It is preferred for the library to return an
actual error code and let the calling program decide how to handle the
situation.

boost-graph-mpich2.i686: W: shared-lib-calls-exit /usr/lib/mpich2/lib/libboost_graph_parallel-mt.so.1.46.0 exit@GLIBC_2.0
This library package calls exit() or _exit(), probably in a non-fork()
context. Doing so from a library is strongly discouraged - when a library
function calls exit(), it prevents the calling program from handling the
error, reporting it to the user, closing files properly, and cleaning up any
state that the program has. It is preferred for the library to return an
actual error code and let the calling program decide how to handle the
situation.

May somebody more knowledged than me please investigate here, whether this exit()/_exit() is acceptable or whether it should be changed/rewritten (and if yes, do so)? Thank you very much.

Attachments

Change History

comment:1 Changed 3 years ago by mcepl@…

  • Cc mcepl@… added

comment:2 Changed 3 years ago by jewillco

  • Status changed from new to closed
  • Resolution set to fixed

(In [73425]) Removed calls to exit(); fixes #5185

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.