Modify

Ticket #6194 (closed Feature Requests: fixed)

Opened 2 years ago

Last modified 23 months ago

Adapt to Boost.Move

Reported by: viboes Owned by: viboes
Milestone: Boost 1.50.0 Component: thread
Version: Boost 1.48.0 Severity: Problem
Keywords: move semantics Cc: viboes

Description

As suggested in the ML Boost.Thread should move to Boost.Move to implement move semantics emulation.

Attachments

6194_0.patch Download (42.7 KB) - added by Evan Wallace <onlyone@…> 2 years ago.
Version 0 of the patch to #6194
6194_1.patch Download (37.5 KB) - added by Evan Wallace <onlyone@…> 2 years ago.
Version 1 of the patch to #6194

Change History

comment:1 Changed 2 years ago by viboes

  • Cc viboes added

comment:2 Changed 2 years ago by viboes

See also:

#2380 boost::move from lvalue does not work with gcc

#2501 upgrade_to_unique_lock doesn't compile on C++0x mode

#4521 Error using boost::move on packaged_task (MSVC 10)

#4705 C++03 Move Support Undocumented

#4711 Must use implementation details to return move-only types

#6141 Compilation error when boost.thread and boost.move are used together

#6174 [thread] packaged_task does correctly handle moving results

These tickets could be closed once the emulation is adopted and of course the problem disappears.

This is one is related but will need more modifications.

#5990 shared_future<T>::get() has wrong return type

comment:3 Changed 2 years ago by viboes

See also #6222 Compile error with SunStudio?: unique_future move

Changed 2 years ago by Evan Wallace <onlyone@…>

Version 0 of the patch to #6194

comment:4 Changed 2 years ago by Evan Wallace <onlyone@…>

Sorry about the long delay.

I have attached a patch should fix this, as well as #2380, #2501, #4521, #6141, #6174 and #5990.

The patch is relative to 1.48.0. The patch does not incorporate any changes made to the trunk since 1.48.0, and also does not incorporate the fixes to #6174 and #5990 that were attached to those tickets by viboes (I had already fixed the problems independently, before noticing about the existence of those patches).

The attached patch is missing tests and documentation. I will send a longer description and justification of the changes to the mailing list.

Changed 2 years ago by Evan Wallace <onlyone@…>

Version 1 of the patch to #6194

comment:5 Changed 2 years ago by Evan Wallace <onlyone@…>

The new patch should address most of the concerns raised in the mailing list so far. The patch is again relative to 1.48.0, and it is still missing tests and documentation.

comment:6 Changed 2 years ago by viboes

  • Owner changed from anthonyw to viboes
  • Status changed from new to assigned

comment:7 Changed 2 years ago by viboes

  • Milestone changed from To Be Determined to Boost 1.49.0

Committed in trunk at revision [76543].

comment:8 Changed 2 years ago by viboes

  • Severity changed from Showstopper to Problem

comment:9 Changed 23 months ago by viboes

  • Status changed from assigned to closed
  • Resolution set to fixed
  • Milestone changed from Boost 1.49.0 to Boost 1.50.0

Committed in release branch at [78543]

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.