Modify

Ticket #6708 (closed Feature Requests: fixed)

Opened 2 years ago

Last modified 2 years ago

Make bool boost::intersects() in is_straight_line_drawing.hpp inline?

Reported by: thekyria@… Owned by: jewillco
Milestone: To Be Determined Component: graph
Version: Boost 1.49.0 Severity: Optimization
Keywords: straight line drawing intersects inline Cc:

Description

I know the function is rather big, but it's just a suggestion.

It would make is_straight_line_drawing.hpp usable as non-member in header (which for the moment is not the case due to intersect()) if the header is included in many files - multiple definition problem, as hereunder.

debug/testB.o: boost/graph/is_straight_line_drawing.hpp:44: multiple definition of `boost::intersects(double, double, double, double, double, double, double, double, double)'
debug/testA.o: boost/graph/is_straight_line_drawing.hpp:44: first defined here

Notice that for other functions in is_straight_line_drawing.hpp (and elsewhere in boost::graph), this is not an issue due to them being templated.

Attachments

Change History

comment:1 Changed 2 years ago by jewillco

  • Status changed from new to closed
  • Resolution set to fixed

(In [77415]) Added "inline" to avoid multiple definition errors; fixes #6708

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.