Modify

Ticket #7752 (closed Support Requests: fixed)

Opened 17 months ago

Last modified 16 months ago

algorithm minmax_element triggers warning with Clang

Reported by: pbristow Owned by: marshall
Milestone: To Be Determined Component: algorithm
Version: Boost Development Trunk Severity: Optimization
Keywords: minmax_element warning clang Cc:

Description

algorithm minmax_element triggers warning with Clang 3.1

if (comp(first, min_result))
  min_result = first, potential_min_result = last;

is flagged as having Cish comma abuse ;-)

Unless I'm missing something subtle, this can easily be avoided with the more C++ish?

if (comp(first, min_result))
{
  min_result = first;
  potential_min_result = last;
}

path attached.

(This does not show when compiling tests, but does show in user code. There are many duplicated warnings from Boost.Test that make it difficult to find other possibly helpful warnings. And hex_test1 aborted...).

Attachments

algorithm_minmax_element Download (602 bytes) - added by pbristow 17 months ago.
Path to suppress warning

Change History

Changed 17 months ago by pbristow

Path to suppress warning

comment:1 Changed 17 months ago by marshall

(In [81876]) Removed use of comma operator; Refs #7752

comment:2 Changed 16 months ago by marshall

  • Status changed from new to closed
  • Resolution set to fixed

(In [82049]) merge bug fix for minmax_element to release; Fixes #7752

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.