Modify

Ticket #8690 (closed Patches: fixed)

Opened 10 months ago

Last modified 10 months ago

duration_units_default - lost return types constness in overridden methods

Reported by: tmmikolajczyk@… Owned by: viboes
Milestone: Boost 1.54.0 Component: chrono
Version: Boost 1.53.0 Severity: Problem
Keywords: Cc:

Description

When implementing custom chrono duration units by deriving from duration_units_default<> I noticed the "get_valid_units_start" and "get_valid_units_end" is declared to return mutable string_type pointer however the base class (duration_units<>) declares them as immutable. The attached patch has been generated with the "git diff --no-prefix" command (I have boost svn repo cloned with the git-svn tool).

Attachments

duration_unit_return_type.patch Download (825 bytes) - added by tmmikolajczyk@… 10 months ago.

Change History

Changed 10 months ago by tmmikolajczyk@…

comment:1 Changed 10 months ago by tmmikolajczyk@…

It concerns the 1.53 version and the latest trunk as well.

comment:2 Changed 10 months ago by viboes

  • Status changed from new to assigned
  • Milestone changed from To Be Determined to Boost 1.54.0

comment:3 Changed 10 months ago by viboes

Thanks for catching this issue. I will try to fix it for 1.54.

Last edited 10 months ago by viboes (previous) (diff)

comment:4 Changed 10 months ago by viboes

Committed revision [84751].

comment:5 Changed 10 months ago by viboes

  • Status changed from assigned to closed
  • Resolution set to fixed

(In [84767]) Chrono: fix #8690.

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.