Ticket #8915 (closed Bugs: fixed)
boost/log/detail/spin_mutex.hpp: Ignores all failures from pthread_* functions
|Reported by:||Jeffrey Walton <noloader@…>||Owned by:||andysem|
|Milestone:||To Be Determined||Component:||log|
|Keywords:||log spinlock pthread API failure||Cc:|
boost/log/detail/spin_mutex.hpp ignores all failures from pthread_* functions. Functions include pthread_spin_init, pthread_spin_lock and pthread_spin_unlock.
A lock failure is usually a bad thing, and I can't come up with scenarios where a silent failure is desired. It will make a bad problem worse by corrupting data or terminating the program.
At minimum (as a user), I would expect for Boost to use BOOST_ASSERT with an appropriate exception in debugging and diagnostic builds; and BOOST_VERIFY with an appropriate exception for release or production builds.
boost/thread/pthread/mutex.hpp and boost/interprocess/sync/posix/mutex.hpp are good examples of a mature implementation. They check for failures and throw exceptions where appropriate.