Modify

Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#3618 closed Patches (fixed)

MSVC Warning suppression fix

Reported by: John Maddock Owned by: Douglas Gregor
Milestone: Boost 1.42.0 Component: function
Version: Boost Development Trunk Severity: Problem
Keywords: Cc:

Description

The attached patch fixes two categories of warnings from MSVC:

  • First it complains that certain variables are assigned values that are not used when in fact it is used to call the type's destructor via f->~Function(). I believe the warning occurs because the type Function is a built in type for which it's destructor is a no-op.
  • Secondly, use of Boost.Test requires /EHa - added as a requirement to the Jamfile.

Let me know if you want me to commit.

Regards, John.

Attachments (1)

warnings.diff (1.6 KB) - added by John Maddock 8 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 8 years ago by anonymous

"(void)f; suppress waring about the value of f not being used (MSVC) "

---> suppress warning

Changed 8 years ago by John Maddock

Attachment: warnings.diff added

comment:2 Changed 8 years ago by John Maddock

Fixed typo in patch.

comment:3 Changed 7 years ago by Jeremiah Willcock

Resolution: fixed
Status: newclosed

(In [62621]) Applied patch from #3618; fixes #3618

comment:4 Changed 7 years ago by Daniel James

(In [70361]) Function: Merge from trunk.

  • Remove extra definition of operator(), since it's inline anyway. Fixes #4765.
  • Make sure that the cv flags are copied when we copy a reference to a function object. Fixes #4325
  • Fully qualified function calls to avoid ambiguity with new additions to standard. Thanks to Conrad Poelman. Fixes #4073
  • Remove iterator workaround for newer versions of Visual Age C++. Thanks to 'ccambly'. Fixes #3912
  • Fix unused variable warning for Visual C++. Fixes #3618
  • Testing flag for Visual C++.
  • Removed all but one old-style cast, prevents GCC warnings, but breaks GCC 2.95.3. Fixes #3410
  • Fixed tab and newline issues from inspection report.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Douglas Gregor.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.