Modify

Opened 4 years ago

Closed 4 years ago

#9029 closed Bugs (fixed)

Misprint in documentation

Reported by: ruslan_baratov@… Owned by: viboes
Milestone: Boost 1.55.0 Component: thread
Version: Boost 1.54.0 Severity: Problem
Keywords: thread doc Cc:

Description

This page http://www.boost.org/doc/libs/1_54_0/doc/html/thread/build.html has misprint 'boost::thread::oprator=='. I guess it's 'boost::thread::operator=='

Attachments (0)

Change History (15)

comment:1 Changed 4 years ago by viboes

Owner: changed from Anthony Williams to viboes
Status: newassigned

comment:2 Changed 4 years ago by viboes

Milestone: To Be DeterminedBoost 1.55.0

Committed revision 85432.

comment:3 Changed 4 years ago by ruslan_baratov@…

Thanks. Do you accept github pull requests?

comment:4 Changed 4 years ago by viboes

Why not. The pb is to which github repository. Could you point me to which one?

comment:5 Changed 4 years ago by ruslan_baratov@…

No, I'm just asking for future. Quote from here:

   Development should continue in Subversion only.

comment:6 Changed 4 years ago by anonymous

I've send 'Fix documentation misprints' to github.

comment:7 in reply to:  6 ; Changed 4 years ago by viboes

Replying to anonymous:

I've send 'Fix documentation misprints' to github.

Where can I see them?

comment:8 in reply to:  7 Changed 4 years ago by ruslan_baratov@…

Replying to viboes:

Replying to anonymous:

I've send 'Fix documentation misprints' to github.

Where can I see them?

github.com/boostorg/thread/pull/1

comment:9 Changed 4 years ago by viboes

Got it.

Committed revision [85485].

comment:10 Changed 4 years ago by ruslan_baratov@…

I've send one more:

Fix with_lock_guard documentation

github.com/boostorg/thread/pull/3

BTW, can't find this function declaration, where is it?

comment:11 Changed 4 years ago by viboes

Committed revision [85492].

The function is not provided. It is just an example.

comment:12 in reply to:  11 ; Changed 4 years ago by ruslan_baratov@…

Replying to viboes:

Committed revision [85492].

Thank you.

The function is not provided. It is just an example.

Why not? Looks nice:

template <class Lockable, class Function, class... Args>
auto with_lock_guard(
    Lockable& m,
    BOOST_FWD_REF(Function) f,
    BOOST_FWD_REF(Args)... args
) -> decltype(f(args...)) {
  boost::lock_guard<Lockable> lock(m);
  return f(args...);
}

comment:13 in reply to:  12 ; Changed 4 years ago by viboes

Replying to ruslan_baratov@…:

Replying to viboes:

Committed revision [85492].

Thank you.

The function is not provided. It is just an example.

Why not? Looks nice:

template <class Lockable, class Function, class... Args>
auto with_lock_guard(
    Lockable& m,
    BOOST_FWD_REF(Function) f,
    BOOST_FWD_REF(Args)... args
) -> decltype(f(args...)) {
  boost::lock_guard<Lockable> lock(m);
  return f(args...);
}

Well. All new function needs documentation, tests, fix bugs :( Please, create a new feature request (patches are as always welcome ;-)

comment:14 in reply to:  13 Changed 4 years ago by ruslan_baratov@…

Replying to viboes:

Well. All new function needs documentation, tests, fix bugs :( Please, create a new feature request (patches are as always welcome ;-)

https://svn.boost.org/trac/boost/ticket/9058

comment:15 Changed 4 years ago by viboes

Resolution: fixed
Status: assignedclosed

Committed revision [85603] on release branch.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain viboes.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.