Modify

Ticket #3618 (closed Patches: fixed)

Opened 4 years ago

Last modified 3 years ago

MSVC Warning suppression fix

Reported by: johnmaddock Owned by: dgregor
Milestone: Boost 1.42.0 Component: function
Version: Boost Development Trunk Severity: Problem
Keywords: Cc:

Description

The attached patch fixes two categories of warnings from MSVC:

  • First it complains that certain variables are assigned values that are not used when in fact it is used to call the type's destructor via f->~Function(). I believe the warning occurs because the type Function is a built in type for which it's destructor is a no-op.
  • Secondly, use of Boost.Test requires /EHa - added as a requirement to the Jamfile.

Let me know if you want me to commit.

Regards, John.

Attachments

warnings.diff Download (1.6 KB) - added by johnmaddock 4 years ago.

Change History

comment:1 Changed 4 years ago by anonymous

"(void)f; suppress waring about the value of f not being used (MSVC) "

---> suppress warning

Changed 4 years ago by johnmaddock

comment:2 Changed 4 years ago by johnmaddock

Fixed typo in patch.

comment:3 Changed 4 years ago by jewillco

  • Status changed from new to closed
  • Resolution set to fixed

(In [62621]) Applied patch from #3618; fixes #3618

comment:4 Changed 3 years ago by danieljames

(In [70361]) Function: Merge from trunk.

  • Remove extra definition of operator(), since it's inline anyway. Fixes #4765.
  • Make sure that the cv flags are copied when we copy a reference to a function object. Fixes #4325
  • Fully qualified function calls to avoid ambiguity with new additions to standard. Thanks to Conrad Poelman. Fixes #4073
  • Remove iterator workaround for newer versions of Visual Age C++. Thanks to 'ccambly'. Fixes #3912
  • Fix unused variable warning for Visual C++. Fixes #3618
  • Testing flag for Visual C++.
  • Removed all but one old-style cast, prevents GCC warnings, but breaks GCC 2.95.3. Fixes #3410
  • Fixed tab and newline issues from inspection report.
View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.