Modify

#11652 closed Bugs (fixed)

Checking __cpp_lib_integer_sequence

Reported by: Mikhail Strelnikov <mikhail.strelnikov@…> Owned by: olli
Milestone: To Be Determined Component: context
Version: Boost 1.59.0 Severity: Cosmetic
Keywords: Cc:

Description

In this line (boost/context/detail/config.hpp):

! defined(cpp_lib_integer_sequence) && cpp_lib_integer_sequence < 201304

If cpp_lib_integer_sequence is not defined, then it is zero and checking against 201304 is redundant - 0 is less than 201304.

If cpp_lib_integer_sequence is defined, then comparinson with 201304 is not evaluated because of short-circuiting.

I think "! defined(cpp_lib_integer_sequence)" should be removed.

Attachments (0)

Change History (4)

comment:1 Changed 22 months ago by Mikhail Strelnikov <mikhail.strelnikov@…>

  • Severity changed from Problem to Cosmetic
  • Version changed from Boost 1.57.0 to Boost 1.59.0

comment:2 Changed 22 months ago by Mikhail Strelnikov <mikhail.strelnikov@…>

  • Component changed from None to coroutine
  • Owner set to olli

comment:3 Changed 22 months ago by Mikhail Strelnikov <mikhail.strelnikov@…>

And, btw, this check won't work for clang+libc++ because of this bug https://llvm.org/bugs/show_bug.cgi?id=18584

comment:4 Changed 17 months ago by olli

  • Component changed from coroutine to context
  • Resolution set to fixed
  • Status changed from new to closed

fixed - in a little bit other way

Add Comment

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain olli.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.