Modify

Opened 2 years ago

Closed 22 months ago

#11652 closed Bugs (fixed)

Checking __cpp_lib_integer_sequence

Reported by: Mikhail Strelnikov <mikhail.strelnikov@…> Owned by: olli
Milestone: To Be Determined Component: context
Version: Boost 1.59.0 Severity: Cosmetic
Keywords: Cc:

Description

In this line (boost/context/detail/config.hpp):

! defined(cpp_lib_integer_sequence) && cpp_lib_integer_sequence < 201304

If cpp_lib_integer_sequence is not defined, then it is zero and checking against 201304 is redundant - 0 is less than 201304.

If cpp_lib_integer_sequence is defined, then comparinson with 201304 is not evaluated because of short-circuiting.

I think "! defined(cpp_lib_integer_sequence)" should be removed.

Attachments (0)

Change History (4)

comment:1 Changed 2 years ago by Mikhail Strelnikov <mikhail.strelnikov@…>

Severity: ProblemCosmetic
Version: Boost 1.57.0Boost 1.59.0

comment:2 Changed 2 years ago by Mikhail Strelnikov <mikhail.strelnikov@…>

Component: Nonecoroutine
Owner: set to olli

comment:3 Changed 2 years ago by Mikhail Strelnikov <mikhail.strelnikov@…>

And, btw, this check won't work for clang+libc++ because of this bug https://llvm.org/bugs/show_bug.cgi?id=18584

comment:4 Changed 22 months ago by olli

Component: coroutinecontext
Resolution: fixed
Status: newclosed

fixed - in a little bit other way

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain olli.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.