Modify

Opened 5 months ago

Closed 4 months ago

#12748 closed Bugs (fixed)

Boost.Test defines a variable called VERSION

Reported by: Benoit Sigoure <tsunanet@…> Owned by: renficiaud
Milestone: Boost 1.64.0 Component: test
Version: Boost 1.63.0 Severity: Problem
Keywords: Cc:

Description

In commit 86bcffe Boost.Test was changed to define a variable called VERSION. This collides with a #define VERSION usually defined by the GNU Autotools.

My workaround at this point is to #undef VERSION before #includeing Boost.Test but that's not tractable (I'm not gonna chase down every single use of Boost.Test in our large codebase).

Attachments (0)

Change History (4)

comment:1 Changed 5 months ago by Adam Majer <amajer@…>

This is a pretty nasty regression.

Generally, it is a terrible idea to use ALL CAPITAL as variable names. These are reserved, by convention, to be used as #defines.

comment:2 Changed 5 months ago by anonymous

  • Milestone changed from To Be Determined to Boost 1.64.0

Fixed in origin/topic/12748-VERSION-macro-clashes.

comment:3 Changed 5 months ago by renficiaud

  • Owner changed from rogeeff to renficiaud

comment:4 Changed 4 months ago by renficiaud

  • Resolution set to fixed
  • Status changed from new to closed

Merged to master, rev a2b73f5d7568e69162dfac213fab87eea0021ec5

Add Comment

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain renficiaud.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.