Modify

Opened 10 years ago

Closed 8 years ago

Last modified 8 years ago

#1735 closed Bugs (fixed)

[website] Wrong HTML on main documentation page.

Reported by: rulatir@… Owned by: Daniel James
Milestone: Website 1.X Component: website
Version: Severity: Cosmetic
Keywords: Cc:

Description

The documentation homepage has subtly wrong HTML that isn't caught by validators. The main section that lists Boost's libraries with short summaries is a HTML definition list with the following opening tag:

<dl class="">

Note the class atribute is an empty string. For some reason this confuses CSS engines of some browsers (including current Konqueror and newest Opera beta) into displaying the contained <dt>s as if they had display="inline" - they are not on new line, except the first one.

Attachments (0)

Change History (14)

comment:1 Changed 10 years ago by René Rivera

Milestone: Website 1.0

comment:2 Changed 10 years ago by René Rivera

Milestone: To Be Determined
Status: newassigned

comment:3 Changed 10 years ago by Daniel James

(In [44594]) Remove class="" - it's causing some compilers some problems. Refs #1735.

comment:4 Changed 10 years ago by Daniel James

That didn't seem to improve things on Konqueror. The generated dots after all the 'dt's are wrapping to the next line. Using a fixed height seems to fix that, although I'm not sure if the height is correct, as a line-height is never specified. I'll check the change into beta.

comment:5 Changed 10 years ago by Daniel James

(In [44596]) Fix the height of the labels in the library list, so that the generated dots can't make them grow. Refs #1735.

comment:6 Changed 10 years ago by Daniel James

(In [45287]) Remove the fixed line height as on some browsers it doesn't match the normal line height and looks a bit wonky. Instead I added a class to the outer dl so that the titles can clear the line, the field names and values are not aligned on safari and opera, but the whole thing looks vaguely reasonable now.

Refs #1735.

comment:7 Changed 10 years ago by Daniel James

(In [45370]) Fix the height of the field names, and set the line height of the values to match. Refs #1735.

I'm not sure why it didn't occur to me to do this before. It looks okay on all the linux browsers. I'll try some more when I get the chance and then merge it into the live site.

comment:8 Changed 10 years ago by Daniel James

(In [45384]) Just set nowrap of the field names - a much simpler solution to the Safari and Opera problems. Refs #1735.

comment:9 Changed 10 years ago by Daniel James

(In [45396]) Merge in layout fix for Safari and Opera. Refs #1735.

comment:10 Changed 9 years ago by René Rivera

Milestone: To Be DeterminedWebsite 1.X

comment:11 Changed 9 years ago by Daniel James

Owner: changed from René Rivera to Daniel James
Status: assignednew

The page still looks awful in konqueror. I'd hoped it'd get fixed in there, since it's been fixed in webkit for a while but I guess it doesn't work like that. It'll be a pity to have to put in a hack just for a minority browser, but I guess it's the only way.

comment:12 Changed 8 years ago by Daniel James

Resolution: fixed
Status: newclosed

Oh, I'm just going to resolve this as fixed. The html is fine. The page looks fine in every recent mainstream browser. I don't have Konqueror installed at the moment, might try it if I get round to installing linux again.

comment:13 Changed 8 years ago by anonymous

Looks fine in Konqueror 4.4.4.

comment:14 Changed 8 years ago by anonymous

Oh good, thanks for letting me know.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Daniel James.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.