Modify

Opened 10 years ago

Closed 10 years ago

Last modified 3 years ago

#1762 closed Bugs (fixed)

BOOST_DISABLE_THREADS should imply BOOST_SP_DISABLE_THREADS

Reported by: jgottman@… Owned by: Peter Dimov
Milestone: Boost 1.36.0 Component: smart_ptr
Version: Boost 1.35.0 Severity: Problem
Keywords: Cc:

Description

When I built my code with BOOST_DISABLE_THREADS defined, I was surprised to have to deal with threading issues in the shared_ptr library. Defining this variable should automatically define BOOST_SP_DISABLE_THREADS, or else the code in <detail/sp_counted_base.hpp> that says

#if defined( BOOST_SP_DISABLE_THREADS )

should really say

#if defined( BOOST_SP_DISABLE_THREADS ) || defined(BOOST_DISABLE_THREADS)

Attachments (0)

Change History (4)

comment:1 Changed 10 years ago by Peter Dimov

Unfortunately, Boost.Config defines BOOST_DISABLE_THREADS in some situations, so I can't rely on it to reflect the user's intent.

comment:2 Changed 10 years ago by nigels@…

I think that either BOOST_DISABLE_THREADS and BOOST_SP_DISABLE_THREADS should have the same effect. The first applies globally across boost, the second only applies to smart pointers. I don't think it should be necessary for BOOST_SP_DISABLE_THREADS to be specified in addition to BOOST_DISABLE_THREADS.

Thanks for your boost efforts!

  • Nigel

comment:3 Changed 10 years ago by Peter Dimov

Resolution: fixed
Status: newclosed

This should be fixed in [44369].

comment:4 Changed 3 years ago by anonymous

please disable boost from my computer

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Peter Dimov.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.