Modify

Opened 9 years ago

Last modified 6 years ago

#2881 new Bugs

Macros conflict: BOOST_HAS_FTIME and BOOST_NO_GETSYSTEMTIMEASFILETIME

Reported by: Andrey Semashev Owned by: az_sw_dude
Milestone: Boost 1.39.0 Component: date_time
Version: Boost 1.38.0 Severity: Problem
Keywords: BOOST_HAS_FTIME BOOST_NO_GETSYSTEMTIMEASFILETIME Cc:

Description

There are two macros related to the WinAPI FILETIME-related functions: BOOST_HAS_FTIME and BOOST_NO_GETSYSTEMTIMEASFILETIME. The first one is documented as the one that is defined if the GetSystemTimeAsFileTime? API is available, whereas the second one is defined when it's not (while other functions and the FILETIME type itself are available). On Windows Mobile it is possible to get both these macros defined, which is quite contradictory to the documentation.

I believe, docs and tests should be corrected so that BOOST_HAS_FTIME is defined if the FILETIME type is available, and BOOST_NO_GETSYSTEMTIMEASFILETIME is only defined when the GetSystemTimeAsFileTime? function is not available. A quick search shows that these macros are only used in Boost.DateTime? and in the described meaning.

Attachments (0)

Change History (4)

comment:1 Changed 8 years ago by John Maddock

Status: newassigned

Will fix: but when we're not in a run-up to release.

comment:2 Changed 6 years ago by Marshall Clow

How about now? ;-)

comment:3 Changed 6 years ago by John Maddock

(In [73058]) Document BOOST_HAS_GETSYSTEMTIMEASFILETIME, add test case, and change test for BOOST_HAS_FTIME. Refs #2881.

comment:4 Changed 6 years ago by John Maddock

Component: configdate_time
Owner: changed from John Maddock to az_sw_dude
Status: assignednew

Fixed in Boost.Config Trunk, but.... note that DateTime?'s use of these macros seems to be in a mess, and frankly BOOST_HAS_GETSYSTEMTIMEASFILETIME could be probably be removed altogether. Reassigning.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain az_sw_dude.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.