Modify

Opened 8 years ago

Closed 6 years ago

#3762 closed Patches (fixed)

Thread can't be compiled with winscw (Codewarrior by Nokia)

Reported by: Yuriy A. Krasnoschek <aka.rider@…> Owned by: viboes
Milestone: Boost 1.49.0 Component: thread
Version: Boost 1.41.0 Severity: Problem
Keywords: Cc:

Description

The problem is several #include directives use quotes (e.g. #include "file.hpp"). If quoted header are replaced with full file path (e.g. #include <boost/thread/detail/file.hpp>) then it's ok.

Also in file boost/thread/pthread/once.hpp include of pthread_mutex_scoped_lock.hpp is duplicated

Patch attached.

Attachments (4)

boost_thread_pthread.diff (2.5 KB) - added by Yuriy A. Krasnoschek <aka.rider@…> 8 years ago.
boost_thread_win32.diff (3.5 KB) - added by Yuriy A. Krasnoschek <aka.rider@…> 8 years ago.
boost_thread_win32.2.diff (3.9 KB) - added by Yuriy A. Krasnoschek <aka.rider@…> 8 years ago.
win32/thread_data.hpp fixed
boost_thread_pthread.2.diff (2.4 KB) - added by Yuriy A. Krasnoschek <aka.rider@…> 8 years ago.

Download all attachments as: .zip

Change History (11)

Changed 8 years ago by Yuriy A. Krasnoschek <aka.rider@…>

Attachment: boost_thread_pthread.diff added

Changed 8 years ago by Yuriy A. Krasnoschek <aka.rider@…>

Attachment: boost_thread_win32.diff added

comment:1 Changed 8 years ago by Yuriy A. Krasnoschek <aka.rider@…>

Just a cosmetic issue in boost/thread/win32/thread_data.hpp include guard is BOOST_THREAD_PTHREAD_THREAD_DATA_HPP

Changed 8 years ago by Yuriy A. Krasnoschek <aka.rider@…>

Attachment: boost_thread_win32.2.diff added

win32/thread_data.hpp fixed

comment:2 Changed 8 years ago by Yuriy A. Krasnoschek <aka.rider@…>

I'm not able to replace attachement. boost_thread_win32.2.diff it's a diff with fixed guard -#ifndef BOOST_THREAD_PTHREAD_THREAD_DATA_HPP -#define BOOST_THREAD_PTHREAD_THREAD_DATA_HPP +#ifndef BOOST_THREAD_WIN32_THREAD_DATA_HPP +#define BOOST_THREAD_WIN32_THREAD_DATA_HPP

comment:3 Changed 8 years ago by Yuriy A. Krasnoschek <aka.rider@…>

Im sorry but I made mistake in boost_thread_pthread.diff

Changed 8 years ago by Yuriy A. Krasnoschek <aka.rider@…>

Attachment: boost_thread_pthread.2.diff added

comment:4 Changed 8 years ago by Steven Watanabe

Component: Nonethread
Owner: set to Anthony Williams

comment:5 Changed 6 years ago by viboes

Milestone: Boost 1.42.0Boost 1.49.0
Owner: changed from Anthony Williams to viboes
Status: newassigned

Committed in trunk revision 75789 (pthread part).

comment:6 Changed 6 years ago by viboes

Committed in trunk At revision: 75802 (win part)

comment:7 Changed 6 years ago by viboes

Resolution: fixed
Status: assignedclosed

Committed in release at #76291

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain viboes.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.