Modify

Opened 7 years ago

Closed 20 months ago

#3897 closed Bugs (fixed)

Test framework does not include <osreldate.h> before testing __FreeBSD_version

Reported by: janm-boost-bug@… Owned by: rogeeff
Milestone: Boost 1.60.0 Component: test
Version: Boost 1.42.0 Severity: Problem
Keywords: test freebsd osreldate version Cc:

Description

The file boost/test/impl/execution_monitor.ipp tests FreeBSD_version without including <osreldate.h> first. This causes compilation warnings about preprocessor symbol redefinitions.

Patch to fix the problem:

diff -dur boost_1_42_0.orig/boost/test/impl/execution_monitor.ipp boost_1_42_0/boost/test/impl/execution_monitor.ipp --- boost_1_42_0.orig/boost/test/impl/execution_monitor.ipp 2009-11-28 20:19:18.000000000 +1100 +++ boost_1_42_0/boost/test/impl/execution_monitor.ipp 2010-02-04 21:23:20.301652051 +1100 @@ -155,6 +155,7 @@

# include <setjmp.h>

# if defined(FreeBSD)

+# include <osreldate.h>

# ifndef SIGPOLL # define SIGPOLL SIGIO

Attachments (0)

Change History (5)

comment:1 Changed 7 years ago by steven_watanabe

  • Resolution set to fixed
  • Status changed from new to closed

(In [62780]) #include <osreldate.h> on FreeBSD. Fixes #3897

comment:2 Changed 4 years ago by chmeeedalf+boost@…

Can somebody please merge this into the branches? It's not in as of 1.54-Beta1 that I can see, and it causes Boost to fail to build on non-x86 FreeBSD.

comment:3 Changed 4 years ago by anonymous

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:4 Changed 4 years ago by anonymous

Reopen for merge request.

comment:5 Changed 20 months ago by renficiaud

  • Milestone changed from Boost 1.43.0 to Boost 1.60.0
  • Resolution set to fixed
  • Status changed from reopened to closed

Milestone set to 1.60, but fix appeared in 1.59.

Add Comment

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain rogeeff.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.