Modify

Opened 8 years ago

Closed 8 years ago

#3968 closed Bugs (fixed)

coordinate_matrix broken on MSVC10

Reported by: Thomas Klimpel Owned by: Gunter
Milestone: Boost 1.43.0 Component: uBLAS
Version: Boost 1.42.0 Severity: Problem
Keywords: Cc:

Description

The swap functions of "index_pair" and "index_triple" in "ublas/storage.hpp" take their argument by value instead of by reference. This is most probably a simple typo.

It doesn't lead to problems on other compilers, because either ADL is not used at all to find custom swap functions in std::sort, or iter_swap is found. MSVC10 seems to be the only compiler (std library) that misses iter_swap, but finds the broken custom swap function.

Attachments (1)

ublas_storage.patch (999 bytes) - added by anonymous 8 years ago.

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by anonymous

Attachment: ublas_storage.patch added

comment:1 Changed 8 years ago by Gunter

(In [60156]) see #3968: added testcase to reproduce problem

test/sparse_view_test.cpp: test case implementation

test/Jamfile.v2: added target for test run

comment:2 Changed 8 years ago by Gunter

(In [60215]) see #3968 : add missing file in yesterdays commit

test/test_coordinate_matrix_sort.cpp: test case for problem related to #3968

note to myself: do not commit after midnight!

comment:3 Changed 8 years ago by Gunter

(In [60623]) see #3968 test/test_coordinate_matrix_sort.cpp: fixed wrong index in check test/utils.hpp: fixed wrong exit code on failure

comment:4 Changed 8 years ago by Gunter

(In [60780]) storage.hpp: see #3968, applied patch to use references instead of copies in swap implementations

comment:5 Changed 8 years ago by Gunter

(In [61111]) see #3968: added line to release notes

comment:6 Changed 8 years ago by Gunter

Resolution: fixed
Status: newclosed

(In [61112]) close #3968: merge 60156,60215,60623,60780,61111 into release

boost/numeric/ublas/storage.hpp libs/numeric/ublas/test/test_coordinate_matrix_sort.cpp libs/numeric/ublas/test/utils.hpp libs/numeric/ublas/test/Jamfile.v2 libs/numeric/ublas/doc/release_notes.htm

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Gunter.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.