Modify

Opened 7 years ago

Closed 7 years ago

#4385 closed Patches (fixed)

Avoid redefining BOOST_NO_TYPEID and BOOST_NO_RTTI for gcc 4.3+

Reported by: nigels.com@… Owned by: johnmaddock
Milestone: Boost 1.44.0 Component: config
Version: Boost 1.43.0 Severity: Cosmetic
Keywords: gcc BOOST_NO_TYPEID BOOST_NO_RTTI NaCl Cc:

Description

Our codebase is configured to use BOOST_NO_TYPEID and BOOST_NO_RTTI for various compiler toolchains. When we use gcc 4.4 as bundled in the Google Native Client (NaCl?) SDK for OSX and Linux, we see compilation warnings due to the autodetection as follows:

//
// RTTI and typeinfo detection is possible post gcc-4.3:
//
#if __GNUC__ * 100 + __GNUC_MINOR__ >= 403
#  ifndef __GXX_RTTI
#     define BOOST_NO_TYPEID
#     define BOOST_NO_RTTI
#  endif
#endif

Our proposed patch is to avoid redefining either of these:

//
// RTTI and typeinfo detection is possible post gcc-4.3:
//
#if __GNUC__ * 100 + __GNUC_MINOR__ >= 403
#  ifndef __GXX_RTTI
#    ifndef BOOST_NO_TYPEID
#      define BOOST_NO_TYPEID
#    endif
#    ifndef BOOST_NO_RTTI
#      define BOOST_NO_RTTI
#    endif
#  endif
#endif

Attachments (1)

boost_gcc_redefines.diff (496 bytes) - added by nigels.com@… 7 years ago.
Patch for boost w.r.t revision 63409

Download all attachments as: .zip

Change History (3)

Changed 7 years ago by nigels.com@…

Patch for boost w.r.t revision 63409

comment:1 Changed 7 years ago by steven_watanabe

  • Component changed from build to config
  • Owner changed from vladimir_prus to johnmaddock

comment:2 Changed 7 years ago by johnmaddock

  • Resolution set to fixed
  • Status changed from new to closed

(In [63439]) Patch for macro redefinitions. Fixes #4385.

Add Comment

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain johnmaddock.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.