Modify

Opened 7 years ago

Closed 7 years ago

#4563 closed Bugs (fixed)

BOOST_AUTO_LINK_TAGGED broken due to misspelled pragma

Reported by: Pekka Seppänen <pexu+boost@…> Owned by: johnmaddock
Milestone: To Be Determined Component: config
Version: Boost 1.44.0 Severity: Problem
Keywords: auto_link BOOST_AUTO_LINK_TAGGED commentcomment C4068 Cc:

Description

Noticed this while surfing around the source code:

As of [61805] BOOST_AUTO_LINK_TAGGED feature was added. However, the implementation in the file boost/config/auto_link.hpp:365 is currently broken as pragma reads:

#  pragma commentcomment(lib, BOOST_LIB_PREFIX BOOST_STRINGIZE(BOOST_LIB_NAME) BOOST_LIB_THREAD_OPT BOOST_LIB_RT_OPT ".lib")

even though it should say:

#  pragma comment(lib, BOOST_LIB_PREFIX BOOST_STRINGIZE(BOOST_LIB_NAME) BOOST_LIB_THREAD_OPT BOOST_LIB_RT_OPT ".lib")

as stated in the original ticket #4041. Because at least MSVC8 emits a mere C4068 (Unknown pragma) warning, this probably went undetected.

Attachments (0)

Change History (1)

comment:1 Changed 7 years ago by johnmaddock

  • Resolution set to fixed
  • Status changed from new to closed

(In [64885]) Fix typo in auto-linking code. Fixes #4563.

Add Comment

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain johnmaddock.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.