Modify

Opened 7 years ago

Closed 7 years ago

#4918 closed Patches (fixed)

concept_check.hpp triggers self-assignment warnings

Reported by: gromer@… Owned by: Marshall Clow
Milestone: To Be Determined Component: concept_check
Version: Boost 1.45.0 Severity: Problem
Keywords: Cc:

Description

boost/concept_check.hpp contains two instances of assigning a variable to itself. In context, this is perfectly safe (since the code should never actually be executed), but it nonetheless triggers gcc's -Wself-assign, cluttering the build output for those who have that flag set, and breaking the build for those who also set -Werror. So far as I can tell, this code can be trivially rewritten to avoid the warning without any correctness or performance impact (see the attached patch).

Attachments (1)

selfassign.patch (1.8 KB) - added by gromer@… 7 years ago.
Patch to fix bug

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by gromer@…

Attachment: selfassign.patch added

Patch to fix bug

comment:1 Changed 7 years ago by Vicente Botet <vicente.botet@…>

Type: BugsPatches

comment:2 Changed 7 years ago by Marshall Clow

(In [67742]) Applied patch - refs #4918; will merge to release after tests cycle

comment:3 Changed 7 years ago by Marshall Clow

Owner: changed from jsiek to Marshall Clow

comment:4 Changed 7 years ago by Marshall Clow

Resolution: fixed
Status: newclosed

(In [67792]) Merging fixes to release; fixes #2294 fixes #4918 fixes #3645 refs #2823 refs #1427 refs #2893

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Marshall Clow.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.