Modify

Opened 7 years ago

Closed 6 years ago

#4991 closed Patches (fixed)

uuid compile errors and warnings

Reported by: olim@… Owned by: Andy Tompkins
Milestone: Boost 1.46.0 Component: uuid
Version: Boost 1.45.0 Severity: Problem
Keywords: Cc:

Description

Can someone please apply this patch to boost uuid? This patch fixes a compile error and warning when using a Green Hills compiler.

Attachments (1)

uuid.patch (1.3 KB) - added by olim@… 7 years ago.
Compile error fix for GHS compiler

Download all attachments as: .zip

Change History (9)

Changed 7 years ago by olim@…

Attachment: uuid.patch added

Compile error fix for GHS compiler

comment:1 Changed 7 years ago by Marshall Clow

What is the call that is in <memory.h> ?

comment:2 Changed 7 years ago by Andy Tompkins

I agree with the fix in string_generator.hpp. In seed_rng.hpp ::memcpy is used from <memory.h>

comment:3 Changed 7 years ago by anonymous

So the green hills library doesn't have memcpy in <cstring>, which is what the standard requires?

comment:4 Changed 7 years ago by Marshall Clow

Anonymous ==> marshall in the last comment.

comment:5 Changed 7 years ago by Andy Tompkins

Ah, I see. I was reading things wrong. Right, memcpy should be in <cstring>. I am no longer sure why <memory.h> is included. Maybe I was reading things wrong much earlier in this file's life. If no tests on any platform fail after removing the #include line, I see no reason to not remove it completely.

comment:6 Changed 7 years ago by olim@…

The green hills compiler does have memcpy in <cstring>, but it does not have <memory.h>. Well, it looks like you guys figured it out already.

comment:7 Changed 7 years ago by Andy Tompkins

Removed semicolon from string_generator.hpp. Removed #include <memory.h> from seed_rng.hpp. Committed to trunk.

comment:8 Changed 6 years ago by Andy Tompkins

Resolution: fixed
Status: newclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Andy Tompkins.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.