Modify

Opened 6 years ago

Closed 5 years ago

#6406 closed Bugs (fixed)

Use attribute names with underscores for GCC

Reported by: Petr Machata <pmachata@…> Owned by: Eric Niebler
Milestone: Boost 1.51.0 Component: xpressive
Version: Boost 1.50.0 Severity: Problem
Keywords: Cc:

Description

... which should prevent accidental interactions between user-defined macros and boost internals.

Attachments (1)

boost-xpressive.patch (657 bytes) - added by Petr Machata <pmachata@…> 6 years ago.

Download all attachments as: .zip

Change History (10)

Changed 6 years ago by Petr Machata <pmachata@…>

Attachment: boost-xpressive.patch added

comment:1 Changed 6 years ago by Petr Machata <pmachata@…>

Component: Nonexpressive
Owner: set to Eric Niebler

comment:2 Changed 6 years ago by Eric Niebler

Can you point to official gcc documentation that show that this is a supported and equivalent syntax? All I see is here: http://gcc.gnu.org/onlinedocs/gcc/Attribute-Syntax.html, which seems to indicate that the original code is the correct form. And if the form you suggested is allowed, then is it only a recent addition?

comment:3 Changed 6 years ago by Eric Niebler

Resolution: invalid
Status: newclosed

Resolving as invalid for now. If you can show that this has been supported syntax for a long time, feel free to reopen.

comment:4 Changed 6 years ago by Petr Machata <pmachata@…>

I updated the ticket #6416 with some evidence that this is a long-supported feature.

comment:5 Changed 6 years ago by Petr Machata <pmachata@…>

Resolution: invalid
Status: closedreopened

comment:6 Changed 6 years ago by Petr Machata <pmachata@…>

The double underscore feature is described here: http://gcc.gnu.org/onlinedocs/gcc/Function-Attributes.html and it has worked "forever" (I tried GCC 3.3, but reportedly it's been supported all the way back to GCC 2.95.7).

comment:7 Changed 6 years ago by Eric Niebler

Resolution: fixed
Status: reopenedclosed

(In [76766]) use underscores in gcc attribute names, fixes #6406

comment:8 Changed 5 years ago by Denis Arnaud

Milestone: To Be DeterminedBoost 1.51.0
Resolution: fixed
Status: closedreopened
Version: Boost 1.48.0Boost 1.50.0

The bug has been fixed on trunk (http://svn.boost.org/svn/boost/trunk/boost/xpressive/detail/core/adaptor.hpp), but not on the release branch (http://svn.boost.org/svn/boost/branches/release/boost/xpressive/detail/core/adaptor.hpp)...

Could you integrate the fix in the release branch as well?

comment:9 Changed 5 years ago by Eric Niebler

Resolution: fixed
Status: reopenedclosed

Oops. Merged to release in [79614]. Thanks for spotting that.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Eric Niebler.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.