Modify

Opened 6 years ago

Closed 6 years ago

#6708 closed Feature Requests (fixed)

Make bool boost::intersects() in is_straight_line_drawing.hpp inline?

Reported by: thekyria@… Owned by: Jeremiah Willcock
Milestone: To Be Determined Component: graph
Version: Boost 1.49.0 Severity: Optimization
Keywords: straight line drawing intersects inline Cc:

Description

I know the function is rather big, but it's just a suggestion.

It would make is_straight_line_drawing.hpp usable as non-member in header (which for the moment is not the case due to intersect()) if the header is included in many files - multiple definition problem, as hereunder.

debug/testB.o: boost/graph/is_straight_line_drawing.hpp:44: multiple definition of `boost::intersects(double, double, double, double, double, double, double, double, double)'
debug/testA.o: boost/graph/is_straight_line_drawing.hpp:44: first defined here

Notice that for other functions in is_straight_line_drawing.hpp (and elsewhere in boost::graph), this is not an issue due to them being templated.

Attachments (0)

Change History (1)

comment:1 Changed 6 years ago by Jeremiah Willcock

Resolution: fixed
Status: newclosed

(In [77415]) Added "inline" to avoid multiple definition errors; fixes #6708

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jeremiah Willcock.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.