Modify

Opened 5 years ago

Closed 5 years ago

#6708 closed Feature Requests (fixed)

Make bool boost::intersects() in is_straight_line_drawing.hpp inline?

Reported by: thekyria@… Owned by: jewillco
Milestone: To Be Determined Component: graph
Version: Boost 1.49.0 Severity: Optimization
Keywords: straight line drawing intersects inline Cc:

Description

I know the function is rather big, but it's just a suggestion.

It would make is_straight_line_drawing.hpp usable as non-member in header (which for the moment is not the case due to intersect()) if the header is included in many files - multiple definition problem, as hereunder.

debug/testB.o: boost/graph/is_straight_line_drawing.hpp:44: multiple definition of `boost::intersects(double, double, double, double, double, double, double, double, double)'
debug/testA.o: boost/graph/is_straight_line_drawing.hpp:44: first defined here

Notice that for other functions in is_straight_line_drawing.hpp (and elsewhere in boost::graph), this is not an issue due to them being templated.

Attachments (0)

Change History (1)

comment:1 Changed 5 years ago by jewillco

  • Resolution set to fixed
  • Status changed from new to closed

(In [77415]) Added "inline" to avoid multiple definition errors; fixes #6708

Add Comment

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain jewillco.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.