Modify

Opened 5 years ago

Closed 5 years ago

#6905 closed Bugs (fixed)

bcp --namespace misses a boost namespace in emplace_args.hpp

Reported by: lukester_null@… Owned by: danieljames
Milestone: To Be Determined Component: unordered
Version: Boost 1.49.0 Severity: Problem
Keywords: Cc:

Description

Using bcp to create a custom namespace doesn't convert:

BOOST_UNORDERED_CONSTRUCT_FROM_TUPLE(10, boost)

Attaching a possible fix (only tried on VC++ 10 so far).

Regards

Luke Elliott.

Attachments (2)

emplace_args.hpp (19.4 KB) - added by lukester_null@… 5 years ago.
Possible fix.
emplace_args.diff (3.3 KB) - added by lukester_null@… 5 years ago.
Possible fix as diff.

Download all attachments as: .zip

Change History (6)

Changed 5 years ago by lukester_null@…

Possible fix.

comment:1 Changed 5 years ago by danieljames

  • Status changed from new to assigned

Can you post it as a diff please?

I had a quick look and I think you're illegally concatenating :: and tuple. A preprocessor concatenation has to create a single token but ::tuple is two tokens. Visual C++ accepts things like that, but it shouldn't really. You probably don't need a concatenation at all, could just say namespace_ tuple and that should work.

I'll look into this in more detail later.

Changed 5 years ago by lukester_null@…

Possible fix as diff.

comment:2 Changed 5 years ago by lukester_null@…

Sure - attached without ##.

comment:3 Changed 5 years ago by danieljames

(In [78491]) Unordered: Fix namespaces for renaming in bcp. Refs #6905.

comment:4 Changed 5 years ago by danieljames

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [78534]) Unordered: Fix bcp namespace fix. Fixes #6905.

Add Comment

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain danieljames.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.