Modify

Opened 11 years ago

Closed 10 years ago

#766 closed Bugs (fixed)

"Bug" in comment (x2)

Reported by: alexis_wilke Owned by: Daryle Walker
Milestone: Component: iostreams
Version: None Severity: Cosmetic
Keywords: Cc:

Description (last modified by Marshall Clow)

This is very low priority!

Hey guys,

In this file:

  http://boost.org/boost/integer.hpp

there is the following comment which says '9=unsigned
long' and the code says '9=unsigned char'. Should
someone get rid of that comment or fix it?

  //  specializatons: 1=long, 2=int, 3=short, 4=signed
char,
  //     6=unsigned long, 7=unsigned int, 8=unsigned
short, 9=unsigned long
  //  no specializations for 0 and 5: requests for a
type > long are in error
  template<> struct int_least_helper<1> { typedef long
least; };
  template<> struct int_least_helper<2> { typedef int
least; };
  template<> struct int_least_helper<3> { typedef short
least; };
  template<> struct int_least_helper<4> { typedef
signed char least; };
  template<> struct int_least_helper<6> { typedef
unsigned long least; };
  template<> struct int_least_helper<7> { typedef
unsigned int least; };
  template<> struct int_least_helper<8> { typedef
unsigned short least; };
  template<> struct int_least_helper<9> { typedef
unsigned char least; };


Attachments (0)

Change History (4)

comment:1 Changed 11 years ago by alexis_wilke

Summary: "Bug" in comment"Bug" in comment (x2)
Logged In: YES 
user_id=554061
Originator: YES

Hi guys,

There seems to be many bad comments... 8-)

You may want to delete two lines in that file:

  boost_1_33_1/boost/iostreams/detail/push.hpp

Both mention:

  Macro: BOOST_IOSTREAMS_DEFINE_PUSH_CONSTRUCTOR(mode, name, helper)).

with (1) the wrong parameters and (2) the wrong name in one case.

Thanks,
Alexis

comment:2 Changed 10 years ago by Marshall Clow

Component: Noneiostreams
Description: modified (diff)
Severity: Problem

comment:3 Changed 10 years ago by Marshall Clow

Severity: ProblemCosmetic

comment:4 Changed 10 years ago by Daryle Walker

Resolution: Nonefixed
Status: assignedclosed

Fixed comments in the repository, both in comment:1 and the main description, as [39062]

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Daryle Walker.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.