Modify

Opened 5 years ago

Closed 5 years ago

#7701 closed Patches (fixed)

locale is missing "std::" in some places

Reported by: tvaneerd@… Owned by: Artyom Beilis
Milestone: To Be Determined Component: locale
Version: Boost 1.52.0 Severity: Problem
Keywords: Cc:

Description

the locale library is missing "std::" in a few places (ie sometimes on time_t, sometimes on mbstate_t), and thus doesn't compile on some configurations.

fixes attached.

Attachments (2)

locale.diff (6.9 KB) - added by tvaneerd@… 5 years ago.
diff of required changes
locale.diff2 (2.2 KB) - added by tvaneerd@… 5 years ago.
couple more I missed

Download all attachments as: .zip

Change History (8)

Changed 5 years ago by tvaneerd@…

Attachment: locale.diff added

diff of required changes

comment:1 Changed 5 years ago by anonymous

Summary: locale is missing "std::" in some placelocale is missing "std::" in some places

comment:2 Changed 5 years ago by Artyom Beilis

On what platform does the build fails?

Also mbstate_t, ptrdiff_t, time_t are part of standard C so including stuff like <time.h> or <stddef.h> should solve the problem as well.

comment:3 Changed 5 years ago by anonymous

Fails on QNX (and/or BlackBerry10). Yes C includes should also work. But in some places std:: was already being used on those types, so I assumed it should go in that direction.

Changed 5 years ago by tvaneerd@…

Attachment: locale.diff2 added

couple more I missed

comment:4 Changed 5 years ago by Artyom Beilis

Status: newassigned

comment:5 Changed 5 years ago by Artyom Beilis

Severity: ShowstopperProblem

comment:6 Changed 5 years ago by Artyom Beilis

Resolution: fixed
Status: assignedclosed

(In [81591]) Fixed #7701 missing "std::" in some places, problem on platforms like QNX, Blackbarry

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Artyom Beilis.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.