Modify

Opened 4 years ago

Closed 4 years ago

#8691 closed Bugs (fixed)

iostate is not checked after scan_keyword call

Reported by: tmmikolajczyk@… Owned by: viboes
Milestone: Boost 1.54.0 Component: chrono
Version: Boost Development Trunk Severity: Problem
Keywords: Cc:

Description

Implementation of the duration_get::do_get_n_d_valid_unit and duration_get::do_get_valid_unit methods calls chrono_detail::scan_keyword and then unconditionally calls the facet.match_n_d_valid_unit and facet.match_valid_unit methods appropriately, no matter what is the value of the iostate flag. IMO, the function should just return value "i" if iostate is not good after the scan_keyword call. The proposed change is attached as a patch. The patch fixes also typos in doxygen comments of those functions.

Attachments (1)

chrono_duration_get_bug_8691.patch (1.7 KB) - added by tmmikolajczyk@… 4 years ago.

Download all attachments as: .zip

Change History (4)

Changed 4 years ago by tmmikolajczyk@…

comment:1 Changed 4 years ago by viboes

  • Milestone changed from To Be Determined to Boost 1.54.0
  • Status changed from new to assigned

Thanks for catching this. I'll try to fix it for 1.54.

comment:2 Changed 4 years ago by viboes

Committed revision [84768].

comment:3 Changed 4 years ago by viboes

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [84793]) Chrono: fix #8691,#8696 and update history.

Add Comment

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain viboes.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.