Modify

Opened 11 years ago

Closed 8 years ago

#903 closed Patches (fixed)

[fix in git] inconsistent usage of function pointer typedefs

Reported by: sebastinas@… Owned by: Dave Abrahams
Milestone: Boost 1.36.0 Component: python USE GITHUB
Version: Boost 1.34.0 Severity: Cosmetic
Keywords: Cc:

Description (last modified by Dave Abrahams)

The us of the function pointer typedef 'convertible_function' is inconsistent in boost/python/converter/registry.hpp and libs/python/converter/registry.cpp.

In registry.hpp 'insert' is defined as 'void insert(void* (*convert)(PyObject?*), type_info)' whereas it's 'void insert(convertible_function, type_info)' in registry.cpp. The same applies to 'void insert(convertible_function, constructor_function, type_info)' and 'void push_back(convertible_function, constructor_function, type_info)'.

The attached patch replaces the function pointers with the appropriate typedefs.

Attachments (0)

Change History (5)

comment:1 Changed 11 years ago by Dave Abrahams

Description: modified (diff)
Owner: changed from david_abrahams to Dave Abrahams
Severity: Showstopper
Status: assignednew

comment:2 Changed 11 years ago by Dave Abrahams

Description: modified (diff)
Milestone: Boost 1.35.0
Reporter: changed from sebastinas to sebastinas@…
Severity: ShowstopperCosmetic
Status: newassigned
Version: Nonerelease 1.34.0

comment:3 Changed 8 years ago by troy d. straszheim

Resolution: Nonefixed
Status: assignedclosed
Summary: inconsistent usage of function pointer typedefs[fix in git] inconsistent usage of function pointer typedefs

comment:4 Changed 8 years ago by troy d. straszheim

Resolution: fixed
Status: closedreopened

oops don't want to close these until the merge is done.

comment:5 Changed 8 years ago by Steven Watanabe

Resolution: fixed
Status: reopenedclosed

(In [62808]) Use the convertible_function typedef instead of the raw function pointer type. Fixes #903

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Dave Abrahams.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.